wangsheng has posted comments on this change. ( http://gerrit.cloudera.org:8080/16143 )
Change subject: IMPALA-9741: Support querying Iceberg table by impala ...................................................................... Patch Set 13: (8 comments) Hi Zoltan, thanks for your review again. I've already modify code and submit test case on Jenkins for patch 13. I will update here when all test cases passed and iceberg query test case worked. http://gerrit.cloudera.org:8080/#/c/16143/11//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/16143/11//COMMIT_MSG@7 PS11, Line 7: querying Iceber > misspelled querying Done http://gerrit.cloudera.org:8080/#/c/16143/11//COMMIT_MSG@9 PS11, Line 9: query > nit: querying Done http://gerrit.cloudera.org:8080/#/c/16143/11//COMMIT_MSG@30 PS11, Line 30: query > querying Done http://gerrit.cloudera.org:8080/#/c/16143/11//COMMIT_MSG@31 PS11, Line 31: decide > decide Done http://gerrit.cloudera.org:8080/#/c/16143/11//COMMIT_MSG@32 PS11, Line 32: transfer this inf > transfer this Done http://gerrit.cloudera.org:8080/#/c/16143/11/common/thrift/CatalogObjects.thrift File common/thrift/CatalogObjects.thrift: http://gerrit.cloudera.org:8080/#/c/16143/11/common/thrift/CatalogObjects.thrift@516 PS11, Line 516: > nit: Plural 's' not needed since the value type of the map is not a list Done http://gerrit.cloudera.org:8080/#/c/16143/11/common/thrift/CatalogObjects.thrift@516 PS11, Line 516: // Data file path md5 and it's file descriptor > nit: please add comment about field 5. Done http://gerrit.cloudera.org:8080/#/c/16143/11/fe/src/main/java/org/apache/impala/catalog/FeIcebergTable.java File fe/src/main/java/org/apache/impala/catalog/FeIcebergTable.java: http://gerrit.cloudera.org:8080/#/c/16143/11/fe/src/main/java/org/apache/impala/catalog/FeIcebergTable.java@258 PS11, Line 258: SourceIdToPartitionCol > SourceIdToPartition Done -- To view, visit http://gerrit.cloudera.org:8080/16143 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I856cfee4f3397d1a89cf17650e8d4fbfe1f2b006 Gerrit-Change-Number: 16143 Gerrit-PatchSet: 13 Gerrit-Owner: wangsheng <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: wangsheng <[email protected]> Gerrit-Comment-Date: Fri, 17 Jul 2020 12:38:09 +0000 Gerrit-HasComments: Yes
