Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/16191 )
Change subject: IMPALA-9889: Fixed flaky test_runtime_filters on Kudu table ...................................................................... Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/16191/4/tests/query_test/test_runtime_filters.py File tests/query_test/test_runtime_filters.py: http://gerrit.cloudera.org:8080/#/c/16191/4/tests/query_test/test_runtime_filters.py@41 PS4, Line 41: is_asan Might be good to use runs_slowly() here instead, to ensure we don't see this same flakiness on ubsan, tsan, etc. http://gerrit.cloudera.org:8080/#/c/16191/4/tests/query_test/test_runtime_filters.py@76 PS4, Line 76: self.execute_query("SET ASYNC_CODEGEN=TRUE") I think rather than doing this for each test case, you can use 'add_exec_option_dimension' in add_test_dimensions above, which will ensure every test in the class is covered. -- To view, visit http://gerrit.cloudera.org:8080/16191 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I94a08e272f0870c04c96563fa614e3416fb5379b Gerrit-Change-Number: 16191 Gerrit-PatchSet: 4 Gerrit-Owner: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-Comment-Date: Mon, 20 Jul 2020 15:33:19 +0000 Gerrit-HasComments: Yes
