Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16120 )
Change subject: IMPALA-9903: Reduce Kudu openTable calls per query ...................................................................... Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/16120/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/16120/2//COMMIT_MSG@9 PS2, Line 9: This patch reduces the number of Kudu openTable calls for a query : by storing the KuduTable object in the FeKuduTable and using it : in places openTable was previously used. I think it would be good to be more specific here. Looks like currently we get the KuduTable object every time in the KuduScanNode which can possibly mean multiple times per query. Do we want to tie this with the invalidate/refresh table mechanism? Or do we want it at once per query granularity? http://gerrit.cloudera.org:8080/#/c/16120/2/fe/src/main/java/org/apache/impala/catalog/KuduTable.java File fe/src/main/java/org/apache/impala/catalog/KuduTable.java: http://gerrit.cloudera.org:8080/#/c/16120/2/fe/src/main/java/org/apache/impala/catalog/KuduTable.java@185 PS2, Line 185: if (kuduTable_ == null) { : KuduClient client = KuduUtil.getKuduClient(getKuduMasterHosts()); : kuduTable_ = client.openTable(getKuduTableName()); : } : return kuduTable_; This would mean that once kuduTable_ is initialized, it never gets refreshed. Even after a explicit refresh command which would call the loadSchemaFromKudu(). http://gerrit.cloudera.org:8080/#/c/16120/2/fe/src/main/java/org/apache/impala/catalog/KuduTable.java@298 PS2, Line 298: kuduTable = getKuduTable(); This probably should be kept as is otherwise we won't see a updated Kudu schema once the table is loaded. -- To view, visit http://gerrit.cloudera.org:8080/16120 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iec12a5be9b30e19a123142af5453a91bd4300b63 Gerrit-Change-Number: 16120 Gerrit-PatchSet: 2 Gerrit-Owner: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Vihang Karajgaonkar <vih...@cloudera.com> Gerrit-Comment-Date: Mon, 20 Jul 2020 19:40:54 +0000 Gerrit-HasComments: Yes
