Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16220 )
Change subject: WIP CDPD-8989 Improve admission control pool stats logging to be more explicit ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/16220/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/16220/1//COMMIT_MSG@7 PS1, Line 7: WIP CDPD-8989 > Can you file an upstream JIRA and add that here instead +1 http://gerrit.cloudera.org:8080/#/c/16220/1/be/src/runtime/mem-tracker.cc File be/src/runtime/mem-tracker.cc: http://gerrit.cloudera.org:8080/#/c/16220/1/be/src/runtime/mem-tracker.cc@411 PS1, Line 411: if (pool_stats.min_memory_consumed > mem_consumed) : pool_stats.min_memory_consumed = mem_consumed; : : if (pool_stats.max_memory_consumed < mem_consumed) : pool_stats.max_memory_consumed = mem_consumed; multi-line if statements need curly braces. -- To view, visit http://gerrit.cloudera.org:8080/16220 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id995a9d044082c3b8f044e1ec25bb4c64347f781 Gerrit-Change-Number: 16220 Gerrit-PatchSet: 1 Gerrit-Owner: Qifan Chen <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Qifan Chen <[email protected]> Gerrit-Reviewer: Sahil Takiar <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Tue, 21 Jul 2020 16:56:23 +0000 Gerrit-HasComments: Yes
