Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16206 )
Change subject: IMPALA-9964: Fill file descriptors properly in setFileMetadataFromFS ...................................................................... IMPALA-9964: Fill file descriptors properly in setFileMetadataFromFS IMPALA-9859 added separate fields for insert and delete file descriptors. They are needed for full ACID tables. I did not set these in CatalogServiceCatalog.setFileMetadataFromFS which could result in a NullPointerException in CatalogdMetaProvider. During the fix I found another bug related to delete delta files. In AcidUtils we did not filter them based on the valid write id list. I fixed this issue as well in this commit. Added unit tests about the issues. Change-Id: I2927171cf426597c86766fb83d565c5e57025c73 Reviewed-on: http://gerrit.cloudera.org:8080/16206 Reviewed-by: Impala Public Jenkins <[email protected]> Tested-by: Impala Public Jenkins <[email protected]> --- M fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java M fe/src/main/java/org/apache/impala/catalog/HdfsPartition.java M fe/src/main/java/org/apache/impala/catalog/HdfsTable.java M fe/src/main/java/org/apache/impala/catalog/ParallelFileMetadataLoader.java M fe/src/main/java/org/apache/impala/util/AcidUtils.java M fe/src/test/java/org/apache/impala/catalog/PartialCatalogInfoWriteIdTest.java M fe/src/test/java/org/apache/impala/util/AcidUtilsTest.java 7 files changed, 139 insertions(+), 36 deletions(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/16206 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I2927171cf426597c86766fb83d565c5e57025c73 Gerrit-Change-Number: 16206 Gerrit-PatchSet: 7 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Vihang Karajgaonkar <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]>
