Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/15963 )
Change subject: IMPALA-6692: Trigger sort node run before hitting memory limit. ...................................................................... Patch Set 20: Patch set 19 fail the same test, test_multiple_sort_run_bytes_limits. Looks like admission controller does not respect buffer_pool_limit as much as mem_limit. Patch set 20 change the test cases to use mem_limit instead of buffer_pool_limit, just as Tim initially suggest. Some of the sort_run_bytes_limit parameter also adjusted to keep the assertions true. Fang-Yu help me verify that this Patch set 20 can pass ubuntu-16.04-dockerised-tests by rerunning it in this jenkins job: https://jenkins.impala.io/job/ubuntu-16.04-dockerised-tests/2814/ -- To view, visit http://gerrit.cloudera.org:8080/15963 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2a0ba7c4bae4f1d300d4d9d7f594f63ced06a240 Gerrit-Change-Number: 15963 Gerrit-PatchSet: 20 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: David Rorke <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Thu, 23 Jul 2020 02:47:18 +0000 Gerrit-HasComments: No
