Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16223 )
Change subject: IMPALA-9979: part 1: factor out Top-N heap. ...................................................................... IMPALA-9979: part 1: factor out Top-N heap. This extracts the implementation of the actual priority queue from the rest of TopNNode's state, so that we can, in the next patch, have multiple heaps per node. The codegen'd InsertBatch() function is unfortunately a little sensitive to minor changes in code, because of the weird way that it does an indirect call via TupleRowComparator - see IMPALA-4065. I had to tweak the code a little to find a variant that performed similarly to the previous version - other variants had small regressions. Perf: Single node TPC-H showed no perf change. The time for the TOP-N node in this targeted query was within the margin of error: use tpch30_parquet; set mt_dop=1; select l_extendedprice from lineitem order by 1 limit 100 Change-Id: I1f585216b547af7a470e02f75458b1901dc44a31 Reviewed-on: http://gerrit.cloudera.org:8080/16223 Reviewed-by: Impala Public Jenkins <[email protected]> Tested-by: Impala Public Jenkins <[email protected]> --- M be/src/codegen/impala-ir.h M be/src/exec/topn-node-ir.cc M be/src/exec/topn-node.cc M be/src/exec/topn-node.h M be/src/util/tuple-row-compare.h 5 files changed, 163 insertions(+), 73 deletions(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/16223 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I1f585216b547af7a470e02f75458b1901dc44a31 Gerrit-Change-Number: 16223 Gerrit-PatchSet: 5 Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]>
