Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16098 )
Change subject: IMPALA-9744: Treat corrupt table stats as missing to avoid bad plans ...................................................................... Patch Set 22: Code-Review+2 (4 comments) Minor nits, otherwise LGTM. http://gerrit.cloudera.org:8080/#/c/16098/22/fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java File fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java: http://gerrit.cloudera.org:8080/#/c/16098/22/fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java@1200 PS22, Line 1200: bad lets stick with referring to these partitions as partitions with either corrupt or missing stats. http://gerrit.cloudera.org:8080/#/c/16098/22/fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java@1232 PS22, Line 1232: if (numRows < -1 || (numRows == 0 && tbl_.getTotalHdfsBytes() > 0)) : hasCorruptTableStats_ = true; the if statement should have curly braces http://gerrit.cloudera.org:8080/#/c/16098/22/tests/metadata/test_compute_stats.py File tests/metadata/test_compute_stats.py: http://gerrit.cloudera.org:8080/#/c/16098/22/tests/metadata/test_compute_stats.py@179 PS22, Line 179: """ this doesn't need to be on a newline. http://gerrit.cloudera.org:8080/#/c/16098/22/tests/metadata/test_compute_stats.py@295 PS22, Line 295: nit: extra new line -- To view, visit http://gerrit.cloudera.org:8080/16098 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9f4c64616ff7c0b6d5a48f2b5331325feeff3576 Gerrit-Change-Number: 16098 Gerrit-PatchSet: 22 Gerrit-Owner: Qifan Chen <qc...@cloudera.com> Gerrit-Reviewer: Aman Sinha <amsi...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com> Gerrit-Reviewer: Sahil Takiar <stak...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Sat, 25 Jul 2020 00:52:33 +0000 Gerrit-HasComments: Yes
