Hello Tim Armstrong, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/16270
to look at the new patch set (#2).
Change subject: IMPALA-10010: Add option to configure metrics webserver
......................................................................
IMPALA-10010: Add option to configure metrics webserver
Currently, when security is turned on for the webui, eg. with
--webserver_require_ldap, authentication is applied to all webui
endpoints.
However, there are some endpoints that expose low-sensitivity info and
which are scraped by other systems that it may be difficult to get
credentials to in order to be able to authenticate.
This patch adds a flag, --metrics_webserver_port, which if specified
turns on an unsecured webserver that exposes only the /metrics,
/jsonmetrics, /metrics_prometheus for all Impala daemons. Impalads
also have the /healthz endpoint exposed.
Testing:
- Added a test that turns on the metrics server and verifies its
reachable and unsecured.
Change-Id: Ibcf297d798a1a5c9cd59d4d82706d2d945e10d3d
---
M be/src/catalog/catalogd-main.cc
M be/src/runtime/exec-env.cc
M be/src/runtime/exec-env.h
M be/src/service/impala-http-handler.cc
M be/src/service/impala-http-handler.h
M be/src/service/impala-server.cc
M be/src/statestore/statestored-main.cc
M be/src/util/metrics.cc
M be/src/util/metrics.h
M be/src/util/webserver.cc
M be/src/util/webserver.h
M fe/src/test/java/org/apache/impala/customcluster/CustomClusterRunner.java
M fe/src/test/java/org/apache/impala/customcluster/LdapWebserverTest.java
M fe/src/test/java/org/apache/impala/util/Metrics.java
14 files changed, 161 insertions(+), 43 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/70/16270/2
--
To view, visit http://gerrit.cloudera.org:8080/16270
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ibcf297d798a1a5c9cd59d4d82706d2d945e10d3d
Gerrit-Change-Number: 16270
Gerrit-PatchSet: 2
Gerrit-Owner: Thomas Tauber-Marshall <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Tim Armstrong <[email protected]>
