Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/16204 )
Change subject: IMPALA-8125: Add query option to limit number of hdfs writer instances ...................................................................... Patch Set 8: Code-Review+2 a test was failing in dockerised tests. The issue was that while checking for whether writer limits need to be applied, i was only checking whether the target table was a HdfsTable or not. I missed checking for its counterpart, LocalFsTable, when local catalog mode is turned on. Since in dockerised testing mode the impala process is started in local catalog mode, this test failed. Carrying forward Tim's +2 -- To view, visit http://gerrit.cloudera.org:8080/16204 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I17c8e61b9a32d908eec82c83618ff9caa41078a5 Gerrit-Change-Number: 16204 Gerrit-PatchSet: 8 Gerrit-Owner: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Tue, 04 Aug 2020 00:51:05 +0000 Gerrit-HasComments: No
