Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16278 )
Change subject: IMPALA-10005: Fix Snappy decompression for non-block filesystems ...................................................................... Patch Set 2: (3 comments) mostly questions http://gerrit.cloudera.org:8080/#/c/16278/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/16278/2//COMMIT_MSG@9 PS2, Line 9: Snappy-compressed text always uses THdfsCompression::SNAPPY_BLOCKED is this true of all engines? do all engines use SNAPPY_BLOCKED for snappy-compressed text? I guess, put another way, if we write snappy-compressed text via Hive, can Impala still read it after this change? http://gerrit.cloudera.org:8080/#/c/16278/2//COMMIT_MSG@10 PS2, Line 10: for non-block filesystems why does this only happen for non-block filesystems? http://gerrit.cloudera.org:8080/#/c/16278/2//COMMIT_MSG@24 PS2, Line 24: Changed the utility function so it doesn't use Hive. adding coverage for S3 is nice, but do we lose any inter-operability coverage here between Hive and Impala? -- To view, visit http://gerrit.cloudera.org:8080/16278 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0879f2fc0bf75bb5c15cecb845ece46a901601ac Gerrit-Change-Number: 16278 Gerrit-PatchSet: 2 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Sahil Takiar <[email protected]> Gerrit-Comment-Date: Thu, 06 Aug 2020 19:30:16 +0000 Gerrit-HasComments: Yes
