Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16098 )
Change subject: IMPALA-9744: Treat corrupt table stats as missing to avoid bad plans ...................................................................... Patch Set 25: (2 comments) http://gerrit.cloudera.org:8080/#/c/16098/25/fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java File fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java: http://gerrit.cloudera.org:8080/#/c/16098/25/fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java@1199 PS25, Line 1199: hasCorruptTableStats_ should this be 'partitionsWithCorruptOrMissingStats.size() != 0' you want to check if any partitions have either corrupt or missing stats, right? http://gerrit.cloudera.org:8080/#/c/16098/25/tests/metadata/test_explain.py File tests/metadata/test_explain.py: http://gerrit.cloudera.org:8080/#/c/16098/25/tests/metadata/test_explain.py@132 PS25, Line 132: # Set the number of rows at the table level to -1. : self.execute_query( : "alter table %s set tblproperties('numRows'='-1')" % mixed_tbl) > It is needed to trigger the code to take the code path of estimation. Witho I think this might actually be a bug (see other comment). only one of the partitions has stats, the others should have missing stats. -- To view, visit http://gerrit.cloudera.org:8080/16098 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9f4c64616ff7c0b6d5a48f2b5331325feeff3576 Gerrit-Change-Number: 16098 Gerrit-PatchSet: 25 Gerrit-Owner: Qifan Chen <qc...@cloudera.com> Gerrit-Reviewer: Aman Sinha <amsi...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com> Gerrit-Reviewer: Sahil Takiar <stak...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Thu, 06 Aug 2020 20:05:51 +0000 Gerrit-HasComments: Yes
