Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16300 )
Change subject: IMPALA-9851: Truncate long error message. ...................................................................... IMPALA-9851: Truncate long error message. Error message length was unbounded and can grow very large into couple of MB in size. This patch truncate error message to maximum 128kb in size. This patch also fix potentially long error message related to BufferPool::Client::DebugString(). Before this patch, DebugString() will print all pages in 'pinned_pages_', 'dirty_unpinned_pages_', and 'in_flight_write_pages_' PageList. With this patch, DebugString() only include maximum of 100 first pages in each PageList. Testing: - Add be test BufferPoolTest.ShortDebugString - Add test within ErrorMsg.GenericFormatting to test for truncation. - Run and pass core tests. Change-Id: Ic9fa4d024fb3dc9de03c7484f41b5e420a710e5a Reviewed-on: http://gerrit.cloudera.org:8080/16300 Reviewed-by: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Tested-by: Impala Public Jenkins <impala-public-jenk...@cloudera.com> --- M be/src/runtime/bufferpool/buffer-pool-internal.h M be/src/runtime/bufferpool/buffer-pool-test.cc M be/src/runtime/bufferpool/buffer-pool.cc M be/src/runtime/bufferpool/buffer-pool.h M be/src/util/error-util-test.cc M be/src/util/error-util.cc M be/src/util/error-util.h M be/src/util/internal-queue.h 8 files changed, 163 insertions(+), 62 deletions(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/16300 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ic9fa4d024fb3dc9de03c7484f41b5e420a710e5a Gerrit-Change-Number: 16300 Gerrit-PatchSet: 4 Gerrit-Owner: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com>
