Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16296 )
Change subject: IMPALA-10053: Remove uses of MonoTime::GetDeltaSince() ...................................................................... IMPALA-10053: Remove uses of MonoTime::GetDeltaSince() MonoTime is a utility Impala imports from Kudu. The behavior of MonoTime::GetDeltaSince() was accidentally flipped in https://gerrit.cloudera.org/#/c/14932/ so we're getting negative durations where we expect positive durations. The function is deprecated anyways, so this patch removes all uses of it and replaces them with the MonoTime '-' operator. Testing: - Manually ran with and without patch and inspected calculated values. - Added DCHECKs to prevent sucn an issue from occurring again. Change-Id: If8cd3eb51a4fd101bbe4b9c44ea9be6ea2ea0d06 Reviewed-on: http://gerrit.cloudera.org:8080/16296 Reviewed-by: Impala Public Jenkins <[email protected]> Tested-by: Impala Public Jenkins <[email protected]> --- M be/src/runtime/krpc-data-stream-recvr.cc M be/src/runtime/krpc-data-stream-sender.cc M be/src/service/data-stream-service.cc 3 files changed, 7 insertions(+), 2 deletions(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/16296 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: If8cd3eb51a4fd101bbe4b9c44ea9be6ea2ea0d06 Gerrit-Change-Number: 16296 Gerrit-PatchSet: 3 Gerrit-Owner: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Sahil Takiar <[email protected]>
