Attila Jeges has posted comments on this change. ( http://gerrit.cloudera.org:8080/16301 )
Change subject: IMPALA-10054: Fix flakiness in test_multiple_sort_run_bytes_limits ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/16301/1/tests/query_test/test_sort.py File tests/query_test/test_sort.py: http://gerrit.cloudera.org:8080/#/c/16301/1/tests/query_test/test_sort.py@90 PS1, Line 90: ' - SpilledRuns:.*' > nit: Perhaps you could use a more complete regex pattern here: Also, please use raw strings for regex patterns, e.g.: r'\s+\- SpilledRuns: %s' % spilled_runs -- To view, visit http://gerrit.cloudera.org:8080/16301 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I84a8b579c943cddba4432cf183f7f002ef8ec6ad Gerrit-Change-Number: 16301 Gerrit-PatchSet: 1 Gerrit-Owner: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Attila Jeges <atti...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Comment-Date: Fri, 07 Aug 2020 11:02:29 +0000 Gerrit-HasComments: Yes
