Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16306 )
Change subject: IMPALA-10061 Fix bugs of IMPALA-9645 ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/16306/1/be/src/codegen/llvm-codegen.cc File be/src/codegen/llvm-codegen.cc: http://gerrit.cloudera.org:8080/#/c/16306/1/be/src/codegen/llvm-codegen.cc@1613 PS1, Line 1613: if (IsCPUFeatureEnabled(CpuInfo::SSE4_2)) { I think it's confusing for readers to #ifdef control flow structures like this. Can you reworked it, e.g. by defining a new constant or macro to something like: if (IS_AARCH64 || IsCPUFeatureEnabled(CpuInfo::SSE4_2). http://gerrit.cloudera.org:8080/#/c/16306/1/be/src/exprs/scalar-fn-call.cc File be/src/exprs/scalar-fn-call.cc: http://gerrit.cloudera.org:8080/#/c/16306/1/be/src/exprs/scalar-fn-call.cc@351 PS1, Line 351: PrimitiveType col_type = children_[i]->type().type; I think you need to undo this change - it caused a clang-tidy failure because it's an unused variable on x86 -- To view, visit http://gerrit.cloudera.org:8080/16306 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I219588992715b7d5c69cd7c0d48ff4d90b980338 Gerrit-Change-Number: 16306 Gerrit-PatchSet: 1 Gerrit-Owner: Anonymous Coward <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Fri, 07 Aug 2020 21:07:59 +0000 Gerrit-HasComments: Yes
