Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/15531 )

Change subject: IMPALA-9544 Replace Intel's SSE instructions with ARM's NEON 
instructions
......................................................................


Patch Set 40:

(8 comments)

http://gerrit.cloudera.org:8080/#/c/15531/40/be/src/util/sse2neon.h
File be/src/util/sse2neon.h:

http://gerrit.cloudera.org:8080/#/c/15531/40/be/src/util/sse2neon.h@213
PS40, Line 213: // 
https://msdn.microsoft.com/en-us/library/bb514059%28v=vs.120%29.aspx?f=255&MSPPError=-2147217396
line too long (99 > 90)


http://gerrit.cloudera.org:8080/#/c/15531/40/be/src/util/sse2neon.h@406
PS40, Line 406: // 
https://docs.microsoft.com/en-us/previous-versions/visualstudio/visual-studio-2010/whtfzhzk(v=vs.100)
line too long (104 > 90)


http://gerrit.cloudera.org:8080/#/c/15531/40/be/src/util/sse2neon.h@413
PS40, Line 413: // 
https://software.intel.com/sites/landingpage/IntrinsicsGuide/#text=_mm_set1_epi64x&expand=4961
line too long (97 > 90)


http://gerrit.cloudera.org:8080/#/c/15531/40/be/src/util/sse2neon.h@1054
PS40, Line 1054: // 
https://software.intel.com/sites/landingpage/IntrinsicsGuide/#text=_mm_shuffle_epi8&expand=5146
line too long (98 > 90)


http://gerrit.cloudera.org:8080/#/c/15531/40/be/src/util/sse2neon.h@1199
PS40, Line 1199: // 
https://docs.microsoft.com/en-us/previous-versions/visualstudio/visual-studio-2010/y41dkk37(v=vs.100)
line too long (104 > 90)


http://gerrit.cloudera.org:8080/#/c/15531/40/be/src/util/sse2neon.h@1645
PS40, Line 1645: // 
https://software.intel.com/sites/landingpage/IntrinsicsGuide/#text=_mm_test_all_zeros&expand=5871
line too long (100 > 90)


http://gerrit.cloudera.org:8080/#/c/15531/40/be/src/util/sse2neon.h@3581
PS40, Line 3581: // 
https://github.com/ColinIanKing/linux-next-mirror/blob/b5f466091e130caaf0735976648f72bd5e09aa84/crypto/aegis128-neon-inner.c#L52
line too long (131 > 90)


http://gerrit.cloudera.org:8080/#/c/15531/40/be/src/util/sse2neon.h@3681
PS40, Line 3681: //         
cpp-compiler-developer-guide-and-reference-allocating-and-freeing-aligned-memory-blocks
line too long (98 > 90)



--
To view, visit http://gerrit.cloudera.org:8080/15531
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id7dfe17125b2910ece54e7dd18b4e4b25d7de8b9
Gerrit-Change-Number: 15531
Gerrit-PatchSet: 40
Gerrit-Owner: Anonymous Coward <zhaoren...@hotmail.com>
Gerrit-Reviewer: Anonymous Coward <zhaoren...@hotmail.com>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com>
Gerrit-Comment-Date: Mon, 10 Aug 2020 11:45:31 +0000
Gerrit-HasComments: Yes

Reply via email to