[email protected] has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/16174 )

Change subject: IMPALA-9925 cast(pow(2, 31) as int) return 2147483647 on aarch64
......................................................................


Patch Set 6:

Hi, Tim and Zoltan
I think int's max value is 2147483647, not 2147483648.
If there is no cast in the expr, such as abs(pow(2,31)) or abs(-1 * pow(2,31)), 
I think 2147483648 is correct.
And if the cast type is bitint, such as abs(cast(pow(2, 31) as bigint)), it 
also should be 2147483648. But now current expr including 'casting to int'. so 
I think 2147483647 is correct.


--
To view, visit http://gerrit.cloudera.org:8080/16174
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I58ab52acebb9bcddbf298efa886fd30ce35f68bf
Gerrit-Change-Number: 16174
Gerrit-PatchSet: 6
Gerrit-Owner: Anonymous Coward <[email protected]>
Gerrit-Reviewer: Anonymous Coward <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Tim Armstrong <[email protected]>
Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]>
Gerrit-Comment-Date: Mon, 10 Aug 2020 12:33:47 +0000
Gerrit-HasComments: No

Reply via email to