Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/16313 )
Change subject: IMPALA-10039 (part 2): Fixed Expr-test crash due to race condition ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/16313/1/be/src/runtime/query-state.h File be/src/runtime/query-state.h: http://gerrit.cloudera.org:8080/#/c/16313/1/be/src/runtime/query-state.h@112 PS1, Line 112: /// Thread-safe, unless noted otherwise. Lets update this to be more informative, i.e. something like: - Init() must be called first. After Init() returns successfully, all other public functions are thread-safe to call unless noted otherwise. - Cancel() is safe to call at any time (before or during Init()). http://gerrit.cloudera.org:8080/#/c/16313/1/be/src/runtime/query-state.cc File be/src/runtime/query-state.cc: http://gerrit.cloudera.org:8080/#/c/16313/1/be/src/runtime/query-state.cc@870 PS1, Line 870: if (instances_prepared_barrier_ == nullptr) return; I think we can avoid this is we just only set 'is_initialized_' to true on successful initialization. -- To view, visit http://gerrit.cloudera.org:8080/16313 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib0d3b9c59924a25b70fa20afeb6e8ca93016eca9 Gerrit-Change-Number: 16313 Gerrit-PatchSet: 1 Gerrit-Owner: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-Comment-Date: Mon, 10 Aug 2020 18:40:38 +0000 Gerrit-HasComments: Yes
