Qifan Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/16220 )
Change subject: IMPALA-9989 Improve admission control pool stats logging ...................................................................... Patch Set 32: (1 comment) http://gerrit.cloudera.org:8080/#/c/16220/27/be/src/scheduling/admission-controller.cc File be/src/scheduling/admission-controller.cc: http://gerrit.cloudera.org:8080/#/c/16220/27/be/src/scheduling/admission-controller.cc@428 PS27, Line 428: // id=0000000200000002:0000000000000004, consumed=18.00 MB, : // id=0000000100000002:0000000000000000, consumed=18.00 MB, : // id=0000000100000002:0000000000000001, consumed=12.00 MB, : // id=0000000200000002:0000000000000002, consumed=9.00 MB : // ], : // total_consumed=77.00 MB : // fraction_of_pool_total_mem=0.6 : string AdmissionController::GetLogStringForTopNQueriesInPool( : const std::string& pool_name) { : // All stats in pool_stats are the starting point to collect top N queries. : PoolStats* pool_stats = GetPoolStats(pool_name, true); : : std::vector<Item> listOfTopNs; : : // Collect for local stats : const TPoolStats& local = pool_stats->local_stats(); : for (auto& query : local.heavy_memory_queries) { : listOfTopNs.emplace_back( : Item(query.memory_consumed, host_id_, query.queryId, nullptr)); : } > Currently we report top mem usage per host. This is due to the following fa An aggregated version over all hosts for a pool is in place. -- To view, visit http://gerrit.cloudera.org:8080/16220 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id995a9d044082c3b8f044e1ec25bb4c64347f781 Gerrit-Change-Number: 16220 Gerrit-PatchSet: 32 Gerrit-Owner: Qifan Chen <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Qifan Chen <[email protected]> Gerrit-Reviewer: Sahil Takiar <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Mon, 10 Aug 2020 20:56:32 +0000 Gerrit-HasComments: Yes
