Adam Tamas has posted comments on this change. ( http://gerrit.cloudera.org:8080/16322 )
Change subject: IMPALA-10066: Fix test_cancellation_mid_command fails ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/16322/3/tests/shell/test_shell_interactive.py File tests/shell/test_shell_interactive.py: http://gerrit.cloudera.org:8080/#/c/16322/3/tests/shell/test_shell_interactive.py@a265 PS3, Line 265: > What's the reason this can now run in parallel with other tests? Shouldn't While it is a cancellation test, we are cancelling a query in its writing phase and not while it's already in the flight, so it should only affect the shell. Since we are using pexpect spawn, this test has its own impala shell to work with. -- To view, visit http://gerrit.cloudera.org:8080/16322 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib80706d52a85d2c19b13fbbe5695934658c0bf7e Gerrit-Change-Number: 16322 Gerrit-PatchSet: 3 Gerrit-Owner: Adam Tamas <ta...@cloudera.com> Gerrit-Reviewer: Adam Tamas <ta...@cloudera.com> Gerrit-Reviewer: Gabor Kaszab <gaborkas...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Comment-Date: Tue, 11 Aug 2020 12:23:21 +0000 Gerrit-HasComments: Yes
