Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16314 )
Change subject: IMPALA-7658: Proper codegen for HiveUdfCall ...................................................................... Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/16314/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/16314/4//COMMIT_MSG@9 PS4, Line 9: Implementing codegen for HiveUdfCall. I guess we still need to remove the final use of GetCodegenedComputeFnWrapper() after this patch, right http://gerrit.cloudera.org:8080/#/c/16314/4/be/src/exprs/hive-udf-call.cc File be/src/exprs/hive-udf-call.cc: http://gerrit.cloudera.org:8080/#/c/16314/4/be/src/exprs/hive-udf-call.cc@288 PS4, Line 288: return builder->CreateCall( I think you should be able to use ToNativePtr() here instead of calling out to these helpers. -- To view, visit http://gerrit.cloudera.org:8080/16314 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2f994dac550f297ed3c88491816403f237d4d747 Gerrit-Change-Number: 16314 Gerrit-PatchSet: 4 Gerrit-Owner: Daniel Becker <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Tue, 11 Aug 2020 23:41:07 +0000 Gerrit-HasComments: Yes
