Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16143 )
Change subject: IMPALA-9741: Support querying Iceberg table by impala ...................................................................... Patch Set 19: (4 comments) http://gerrit.cloudera.org:8080/#/c/16143/19/fe/src/main/java/org/apache/impala/analysis/ShowStatsStmt.java File fe/src/main/java/org/apache/impala/analysis/ShowStatsStmt.java: http://gerrit.cloudera.org:8080/#/c/16143/19/fe/src/main/java/org/apache/impala/analysis/ShowStatsStmt.java@89 PS19, Line 89: // We only get latest partition spec from Iceberg now, so this list only contains line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/16143/19/fe/src/main/java/org/apache/impala/analysis/ShowStatsStmt.java@93 PS19, Line 93: // Iceberg table with partition spec without partition fields is non-partitioned. line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/16143/19/fe/src/main/java/org/apache/impala/planner/IcebergScanNode.java File fe/src/main/java/org/apache/impala/planner/IcebergScanNode.java: http://gerrit.cloudera.org:8080/#/c/16143/19/fe/src/main/java/org/apache/impala/planner/IcebergScanNode.java@115 PS19, Line 115: * 2.The column is part of all partition keys without any transformation (i.e. IDENTITY); line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/16143/19/fe/src/main/java/org/apache/impala/planner/IcebergScanNode.java@117 PS19, Line 117: * We can use case 1 and 3 to filter data files, but also need to evaluate it in the scan, line too long (92 > 90) -- To view, visit http://gerrit.cloudera.org:8080/16143 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I856cfee4f3397d1a89cf17650e8d4fbfe1f2b006 Gerrit-Change-Number: 16143 Gerrit-PatchSet: 19 Gerrit-Owner: wangsheng <[email protected]> Gerrit-Reviewer: Anonymous Coward (606) Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: wangsheng <[email protected]> Gerrit-Comment-Date: Wed, 12 Aug 2020 08:14:20 +0000 Gerrit-HasComments: Yes
