Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16266 )
Change subject: IMPALA-5022: Outer join simplification ...................................................................... Patch Set 7: (4 comments) http://gerrit.cloudera.org:8080/#/c/16266/7/be/src/service/query-options.h File be/src/service/query-options.h: http://gerrit.cloudera.org:8080/#/c/16266/7/be/src/service/query-options.h@210 PS7, Line 210: QUERY_OPT_FN(enable_outer_to_inner_rewrites, ENABLE_OUTER_TO_INNER_REWRITES, TQueryOptionLevel::ADVANCED)\ line too long (108 > 90) http://gerrit.cloudera.org:8080/#/c/16266/7/common/thrift/ImpalaInternalService.thrift File common/thrift/ImpalaInternalService.thrift: http://gerrit.cloudera.org:8080/#/c/16266/7/common/thrift/ImpalaInternalService.thrift@443 PS7, Line 443: 109: optional bool enable_outer_to_inner_rewrites = true; line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/16266/7/fe/src/main/java/org/apache/impala/analysis/Analyzer.java File fe/src/main/java/org/apache/impala/analysis/Analyzer.java: http://gerrit.cloudera.org:8080/#/c/16266/7/fe/src/main/java/org/apache/impala/analysis/Analyzer.java@3464 PS7, Line 3464: * condition on the null-filling table that filters out non‑matching rows. In a left outer line too long (94 > 90) http://gerrit.cloudera.org:8080/#/c/16266/7/fe/src/main/java/org/apache/impala/analysis/Analyzer.java@3465 PS7, Line 3465: * join, the right table is the null-filling table, while it is the left table in a right line too long (91 > 90) -- To view, visit http://gerrit.cloudera.org:8080/16266 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iaa7804033fac68e93f33c387dc68ef67f803e93e Gerrit-Change-Number: 16266 Gerrit-PatchSet: 7 Gerrit-Owner: Xianqing He <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Qifan Chen <[email protected]> Gerrit-Reviewer: Shant Hovsepian <[email protected]> Gerrit-Reviewer: Xianqing He <[email protected]> Gerrit-Comment-Date: Thu, 13 Aug 2020 13:31:51 +0000 Gerrit-HasComments: Yes
