Tim Armstrong has posted comments on this change. (
http://gerrit.cloudera.org:8080/15531 )
Change subject: IMPALA-9544 Replace Intel's SSE instructions with ARM's NEON
instructions
......................................................................
Patch Set 42:
(1 comment)
The rat-check failed. I think we probably need to add that symlink to
bin/rat_exclude_files.txt
20:49:34 UNAPPROVED: be/src/kudu/util/sse2neon.h
I also see other test runs hitting this. I think I see the bug, commented on it
E0813 03:49:17.510347 49722 llvm-codegen.cc:198] Failed to find function L
F0813 03:49:17.538300 49722 llvm-codegen.cc:484] Check failed:
execution_engine_ == nullptr Must Close() before destruction
*** Check failure stack trace: ***
@ 0x51880dc google::LogMessage::Fail()
@ 0x51899cc google::LogMessage::SendToLog()
@ 0x5187a3a google::LogMessage::Flush()
@ 0x518b638 google::LogMessageFatal::~LogMessageFatal()
@ 0x26fdda6 impala::LlvmCodeGen::~LlvmCodeGen()
@ 0x22b7115 boost::checked_delete<>()
@ 0x22b6410 boost::scoped_ptr<>::~scoped_ptr()
@ 0x26f9fd5 impala::LlvmCodeGen::InitializeLlvm()
@ 0x243559d ImpaladMain()
@ 0x1c73de0 main
@ 0x7fe70ee4583f __libc_start_main
@ 0x1c73c78 _start
Picked up JAVA_TOOL_OPTIONS:
-agentlib:jdwp=transport=dt_socket,address=30000,server=y,suspend=n
Wrote minidump to
/home/ubuntu/Impala/logs/data_loading/minidumps/impalad/8a22ece7-87dc-4571-c7d7edb9-98895e92.dmp
http://gerrit.cloudera.org:8080/#/c/15531/42/be/src/codegen/gen_ir_descriptions.py
File be/src/codegen/gen_ir_descriptions.py:
http://gerrit.cloudera.org:8080/#/c/15531/42/be/src/codegen/gen_ir_descriptions.py@246
PS42, Line 246: ir_functions += ["BLOOM_FILTER_INSERT_AVX2",
"_ZN6impala11BloomFilter10InsertAvx2Ej"]
I think this has a bug - this is concatenating a list of strings to a list of
lists of strings.
--
To view, visit http://gerrit.cloudera.org:8080/15531
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id7dfe17125b2910ece54e7dd18b4e4b25d7de8b9
Gerrit-Change-Number: 15531
Gerrit-PatchSet: 42
Gerrit-Owner: Anonymous Coward <[email protected]>
Gerrit-Reviewer: Anonymous Coward <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Tim Armstrong <[email protected]>
Gerrit-Comment-Date: Thu, 13 Aug 2020 17:33:42 +0000
Gerrit-HasComments: Yes
