Thomas Tauber-Marshall has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16313 )
Change subject: IMPALA-10039 (part 2): Fixed Expr-test crash due to race condition ...................................................................... IMPALA-10039 (part 2): Fixed Expr-test crash due to race condition The root cause for crash is that QueryState::Cancel() was called before thread unsafe function QueryState::Init() was completed. This patch fixs the race condition between QueryState::Cancel() and QueryState::Init(). QueryState::Init() is safe to be called at any time. Testing: - The issue could be reproduced by running expr-test for 10-20 iterations. Verified the fixing by running expr-test over 1000 iterations without crash. - Passed TestProcessFailures::test_kill_coordinator. - Passed core tests. Change-Id: Ib0d3b9c59924a25b70fa20afeb6e8ca93016eca9 Reviewed-on: http://gerrit.cloudera.org:8080/16313 Tested-by: Impala Public Jenkins <[email protected]> Reviewed-by: Thomas Tauber-Marshall <[email protected]> --- M be/src/runtime/query-state.cc M be/src/runtime/query-state.h 2 files changed, 32 insertions(+), 7 deletions(-) Approvals: Impala Public Jenkins: Verified Thomas Tauber-Marshall: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/16313 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ib0d3b9c59924a25b70fa20afeb6e8ca93016eca9 Gerrit-Change-Number: 16313 Gerrit-PatchSet: 4 Gerrit-Owner: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]>
