Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16341 )
Change subject: IMPALA-7714: try to avoid be test crash in statestore ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/16341/1/be/src/statestore/statestore.cc File be/src/statestore/statestore.cc: http://gerrit.cloudera.org:8080/#/c/16341/1/be/src/statestore/statestore.cc@396 PS1, Line 396: // IMPALA-7714: log warning to aid debugging. > Should the logging go before the DCHECK? This was mainly targeted at release builds, but yeah, makes sense. I also added the topic id to the DCHECK cause that'd be useful. -- To view, visit http://gerrit.cloudera.org:8080/16341 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id4363a93addb8a808d292906cac44ebd25c16889 Gerrit-Change-Number: 16341 Gerrit-PatchSet: 1 Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Andrew Sherman <asher...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Fri, 14 Aug 2020 23:20:31 +0000 Gerrit-HasComments: Yes
