Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16351 )
Change subject: IMPALA-10065: Fix DCHECK when retrying a query in FINISHED state ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/16351/1/be/src/runtime/query-driver.cc File be/src/runtime/query-driver.cc: http://gerrit.cloudera.org:8080/#/c/16351/1/be/src/runtime/query-driver.cc@99 PS1, Line 99: If fetch() is called but nothing was fetched (e.g. due to fetch() : // timeout), the query is still retryable. is this change necessary? fetched_rows is only set after WaitForResults returns and timed_out = false, so it should be guaranteed that rows are available for fetching. -- To view, visit http://gerrit.cloudera.org:8080/16351 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I11d82bf80640760a47325833463def8a3791bdda Gerrit-Change-Number: 16351 Gerrit-PatchSet: 1 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Sahil Takiar <[email protected]> Gerrit-Comment-Date: Sun, 23 Aug 2020 19:34:41 +0000 Gerrit-HasComments: Yes
