Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/16363 )
Change subject: IMPALA-4364: [Addendum] Compare specific fields in StorageDescriptor ...................................................................... Patch Set 1: Code-Review+2 (2 comments) LGTM. Just have some nits. http://gerrit.cloudera.org:8080/#/c/16363/1/fe/src/main/java/org/apache/impala/catalog/HdfsPartition.java File fe/src/main/java/org/apache/impala/catalog/HdfsPartition.java: http://gerrit.cloudera.org:8080/#/c/16363/1/fe/src/main/java/org/apache/impala/catalog/HdfsPartition.java@961 PS1, Line 961: compare nit: "compare" usually returns 0 for equals and non-zero values for larger or smaller than the target. What about rename to something like "sdEquals"? http://gerrit.cloudera.org:8080/#/c/16363/1/fe/src/test/java/org/apache/impala/catalog/HdfsPartitionSdCompareTest.java File fe/src/test/java/org/apache/impala/catalog/HdfsPartitionSdCompareTest.java: http://gerrit.cloudera.org:8080/#/c/16363/1/fe/src/test/java/org/apache/impala/catalog/HdfsPartitionSdCompareTest.java@43 PS1, Line 43: hmsPartition nit: hmsPartition_ -- To view, visit http://gerrit.cloudera.org:8080/16363 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I90c797060265f8f508d0b150e15da3d0f9961b9b Gerrit-Change-Number: 16363 Gerrit-PatchSet: 1 Gerrit-Owner: Vihang Karajgaonkar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Tue, 25 Aug 2020 23:57:28 +0000 Gerrit-HasComments: Yes
