Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16349 )
Change subject: IMPALA-7310: Partial fix for NDV cardinality with NULLs. ...................................................................... Patch Set 5: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/16349/5/fe/src/main/java/org/apache/impala/catalog/ColumnStats.java File fe/src/main/java/org/apache/impala/catalog/ColumnStats.java: http://gerrit.cloudera.org:8080/#/c/16349/5/fe/src/main/java/org/apache/impala/catalog/ColumnStats.java@214 PS5, Line 214: if (numDistinctValues_ <= 0 && hasNulls()) { I talked to you directly about this There's the weird case that is extremely unlikely to happen where ndv < 0 and there is a valid numNulls stat. I don't think we should to complicate the code to handle that, but it would be more obviously correct to have it be == 0. Ok to ignore though. -- To view, visit http://gerrit.cloudera.org:8080/16349 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iec967053b4991f8c67cde62adf003cbd3f429032 Gerrit-Change-Number: 16349 Gerrit-PatchSet: 5 Gerrit-Owner: Shant Hovsepian <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: David Rorke <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Qifan Chen <[email protected]> Gerrit-Reviewer: Shant Hovsepian <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Thu, 27 Aug 2020 20:13:50 +0000 Gerrit-HasComments: Yes
