Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16350 )
Change subject: IMPALA-10099: Push down DISTINCT in Set operations ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/16350/3/fe/src/main/java/org/apache/impala/analysis/StmtRewriter.java File fe/src/main/java/org/apache/impala/analysis/StmtRewriter.java: http://gerrit.cloudera.org:8080/#/c/16350/3/fe/src/main/java/org/apache/impala/analysis/StmtRewriter.java@258 PS3, Line 258: if (firstOpStmt.getTableRefs().size() > 0 Do we have planner test for these cases where it doesn't push down the distinct? I looked at setoperation-rewrite.test and didn't see any examples with an empty from clause, or analytic functions or group by. -- To view, visit http://gerrit.cloudera.org:8080/16350 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia248f1595df2ab48fbe70c778c7c32bde5c518a5 Gerrit-Change-Number: 16350 Gerrit-PatchSet: 3 Gerrit-Owner: Shant Hovsepian <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: David Rorke <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Shant Hovsepian <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Sat, 29 Aug 2020 01:20:25 +0000 Gerrit-HasComments: Yes
