Zoltan Borok-Nagy has posted comments on this change. (
http://gerrit.cloudera.org:8080/16143 )
Change subject: IMPALA-9741: Support querying Iceberg table by impala
......................................................................
Patch Set 28:
Yeah, I was thinking about adding
@classmethod
def add_test_dimensions(cls):
super(TestCreatingIcebergTable, cls).add_test_dimensions()
cls.ImpalaTestMatrix.add_constraint(
lambda v: v.get_value('table_format').file_format == 'parquet')
to class TestCreatingIcebergTable. Since Parquet is kind of hard-coded to the
tests, it has no additional value to run the tests with different file formats
in the file format dimension.
Regarding to the build error, it was caused by IMPALA-9923 which is an
unrelated issue.
--
To view, visit http://gerrit.cloudera.org:8080/16143
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I856cfee4f3397d1a89cf17650e8d4fbfe1f2b006
Gerrit-Change-Number: 16143
Gerrit-PatchSet: 28
Gerrit-Owner: wangsheng <[email protected]>
Gerrit-Reviewer: Anonymous Coward (606)
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Tim Armstrong <[email protected]>
Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]>
Gerrit-Reviewer: wangsheng <[email protected]>
Gerrit-Comment-Date: Wed, 02 Sep 2020 08:15:35 +0000
Gerrit-HasComments: No
