Aman Sinha has posted comments on this change. ( http://gerrit.cloudera.org:8080/16346 )
Change subject: IMPALA-10064: Support constant propagation for eligible range predicates ...................................................................... Patch Set 14: > Patch Set 13: > > > Patch Set 12: > > > > > Patch Set 12: Verified-1 > > > > > > Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/6385/ > > > > 1 failure in org.apache.impala.planner.PlannerTest.testConstantPropagation: > > (this contains new tests added for this CR): seems related to ordering of > > the predicates and stats difference. The test passes on my dev machine. > > > > Actual does not match expected result: > > PLAN-ROOT SINK > > | > > 00:SCAN HDFS [functional.alltypes_date_partition] > > partition predicates: date_col >= DATE '2009-01-01' AND date_col <= DATE > > '2009-02-01' > > HDFS partitions=32/55 files=32 size=15.99KB > > predicates: functional.alltypes_date_partition.int_col < 100, > > functional.alltypes_date_partition.timestamp_col <= TIMESTAMP '2009-02-01 > > 00:00:00', functional.alltypes_date_partition.timestamp_col >= TIMESTAMP > > '2009-01-01 00:00:00', functional.alltypes_date_partition.bigint_col IN (5, > > 10), date_col = CAST(timestamp_col AS DATE) > > ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ > > row-size=64B cardinality=26 > > > > Expected: > > PLAN-ROOT SINK > > | > > 00:SCAN HDFS [functional.alltypes_date_partition] > > partition predicates: date_col >= DATE '2009-01-01' AND date_col <= DATE > > '2009-02-01' > > HDFS partitions=32/55 files=32 size=15.99KB > > predicates: functional.alltypes_date_partition.bigint_col IN (5, 10), > > functional.alltypes_date_partition.int_col < 100, > > functional.alltypes_date_partition.timestamp_col <= TIMESTAMP '2009-02-01 > > 00:00:00', functional.alltypes_date_partition.timestamp_col >= TIMESTAMP > > '2009-01-01 00:00:00', date_col = CAST(timestamp_col AS DATE) > > row-size=65B cardinality=13 > > > > There's also 1 failure in > > org.apache.impala.service.FrontendTest.TestGetTablesTypeTable which I > > didn't quite understand yet. > > 1st failure was due to stats not present. On my local machine I think I had > run the compute stats manually. I have added the alltypes_date_partition to > the compute-table-stats.sh script. Second failure needed a minor update to > the FrontendTest.java. There's some discrepancy in the Jenkins run vs my local one..it seems the table 'functional.alltypes_datasource' was never loaded on my local machine and I am not sure how to load it. In any case, I have made an update to the FrontendTest.java in PatchSet14 that should hopefully work now. -- To view, visit http://gerrit.cloudera.org:8080/16346 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I811a1f8d605c27c7704d7fc759a91510c6db3c2b Gerrit-Change-Number: 16346 Gerrit-PatchSet: 14 Gerrit-Owner: Aman Sinha <amsi...@cloudera.com> Gerrit-Reviewer: Aman Sinha <amsi...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com> Gerrit-Reviewer: Shant Hovsepian <sh...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Wed, 02 Sep 2020 17:13:18 +0000 Gerrit-HasComments: No
