Wenzhe Zhou has uploaded a new patch set (#7). ( http://gerrit.cloudera.org:8080/16369 )
Change subject: IMPALA-9636: Don't run retried query on the blacklisted nodes ...................................................................... IMPALA-9636: Don't run retried query on the blacklisted nodes When a node is blacklisted, it is only placed on the blacklist for a certain period of time. For the current implementation, it is possible that the retried query could end up running on the node that it blacklisted during its original attempt. To avoid same failure for the retried query, we should not schedule query fragment instances on the blacklisted nodes which caused the original query to fail. This patch filters out the executors from executor group for those nodes which are blacklisted during its original attempt when make schedule for the retried query. Adds one debug_action to allow delay to be injected when submitting the admission for retried query. Adds new test cases test_retry_exec_rpc_failure_with_admin_delay() and test_retry_query_failure_no_executor_available() for retried query which are triggered by RPC failure. Testing: - Passed test_query_retries.py, including the new test cases. - Passed core tests. Change-Id: I00bc1b5026efbd0670ffbe57bcebc457d34cb105 --- M be/src/runtime/coordinator.cc M be/src/runtime/coordinator.h M be/src/runtime/query-driver.cc M be/src/runtime/query-driver.h M be/src/scheduling/admission-controller.cc M be/src/scheduling/admission-controller.h M be/src/scheduling/executor-group.cc M be/src/scheduling/executor-group.h M be/src/scheduling/scheduler.cc M be/src/service/client-request-state.cc M be/src/service/client-request-state.h M be/src/service/impala-server.cc M tests/custom_cluster/test_query_retries.py 13 files changed, 286 insertions(+), 28 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/69/16369/7 -- To view, visit http://gerrit.cloudera.org:8080/16369 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I00bc1b5026efbd0670ffbe57bcebc457d34cb105 Gerrit-Change-Number: 16369 Gerrit-PatchSet: 7 Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com> Gerrit-Reviewer: Sahil Takiar <stak...@cloudera.com> Gerrit-Reviewer: Thomas Tauber-Marshall <tmarsh...@cloudera.com> Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
