Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/16421 )
Change subject: IMPALA-10140: Fix CatalogExeception for creating database with sync_ddl as true ...................................................................... Patch Set 2: (1 comment) LGTM, just have a minor comment. http://gerrit.cloudera.org:8080/#/c/16421/2/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java: http://gerrit.cloudera.org:8080/#/c/16421/2/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@1298 PS2, Line 1298: if (syncDdl) { Could you move the "syncDdl" check before acquiring the db lock? If syncDdl=false, we don't need the added logic here. -- To view, visit http://gerrit.cloudera.org:8080/16421 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id623118f8938f416414c45d93404fb70d036a9df Gerrit-Change-Number: 16421 Gerrit-PatchSet: 2 Gerrit-Owner: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Tue, 08 Sep 2020 07:29:05 +0000 Gerrit-HasComments: Yes
