Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/16422 )
Change subject: IMPALA_10146: skip test_full_acid_schema_without_file_metadata_tag on non-HDFS file systems ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/16422/1/tests/query_test/test_acid.py File tests/query_test/test_acid.py: http://gerrit.cloudera.org:8080/#/c/16422/1/tests/query_test/test_acid.py@319 PS1, Line 319: @SkipIf.not_hdfs : def test_full_acid_schema_without_file_metadata_tag(self, vector, unique_database): : """IMPALA-10115: Some files have full ACID schema without having : 'hive.acid.version' set. We still need to identify such files as full ACID""" : table_name = "f > Is this equivalent to SkipIf.not_hdfs? They are not exactly equivalent because of the reason text, but actually 'SkipIf.not_hdfs' is more appropriate here. Thanks. -- To view, visit http://gerrit.cloudera.org:8080/16422 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I43a8d940e6b0586ed4241dca3f114393b3b8ec6c Gerrit-Change-Number: 16422 Gerrit-PatchSet: 2 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Wed, 09 Sep 2020 08:29:39 +0000 Gerrit-HasComments: Yes
