Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16426 )
Change subject: IMPALA-9740, IMPALA-9403: Fix remaining custom cluster TSAN errors ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/16426/1/be/src/runtime/dml-exec-state.cc File be/src/runtime/dml-exec-state.cc: http://gerrit.cloudera.org:8080/#/c/16426/1/be/src/runtime/dml-exec-state.cc@171 PS1, Line 171: lock_guard<mutex> l(filesystem_connection_cache_lock); > I think it would be cleaner if HdfsOperationSet wrapped GetConnection() in Changed it so that the lock is owned by HdfsOperationSet, and is not exposed outside HdfsOperationSet. -- To view, visit http://gerrit.cloudera.org:8080/16426 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If1658a9b56d220e2cfd1f8b958604edcdf7757f4 Gerrit-Change-Number: 16426 Gerrit-PatchSet: 1 Gerrit-Owner: Sahil Takiar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Sahil Takiar <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Wed, 09 Sep 2020 22:56:11 +0000 Gerrit-HasComments: Yes
