Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16344 )
Change subject: IMPALA-10093: Replace urllib with curl to download python deps ...................................................................... Patch Set 1: (1 comment) Not sure about introducing the dependency on curl - we don't have it available in all environments at the moment I think - see IMPALA-8987 Can you use wget instead of curl. We already use wget in bin/bootstrap_toolchain.py so that is not introducing a new dependency. http://gerrit.cloudera.org:8080/#/c/16344/1/infra/python/deps/pip_download.py File infra/python/deps/pip_download.py: http://gerrit.cloudera.org:8080/#/c/16344/1/infra/python/deps/pip_download.py@36 PS1, Line 36: try: Can you remove the unused imports? -- To view, visit http://gerrit.cloudera.org:8080/16344 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I146d93312701fd682420cb65cf4738bc030f3cfb Gerrit-Change-Number: 16344 Gerrit-PatchSet: 1 Gerrit-Owner: guojingfeng <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Thu, 10 Sep 2020 00:02:39 +0000 Gerrit-HasComments: Yes
