Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16406 )
Change subject: IMPALA-9229: impala-shell 'profile' to show original and retried queries ...................................................................... Patch Set 3: (12 comments) I updated the patch to include your suggestions from https://issues.apache.org/jira/browse/IMPALA-9870?focusedCommentId=17188243&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-17188243 so the format of the profile command is: PROFILE [ALL | LATEST | ORIGINAL] The core functionality is done, I haven't added tests yet. Just looking for any feedback first to make sure the implementation is correct, then I will add tests. http://gerrit.cloudera.org:8080/#/c/16406/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/16406/2//COMMIT_MSG@23 PS2, Line 23: impala-shell has been modified to dump both the most recent query : attempt and the original query attempt. > I think dumping all profiles may break some tools that grep results from th I updated the patch to include your suggestion to modify the profile command. http://gerrit.cloudera.org:8080/#/c/16406/2//COMMIT_MSG@27 PS2, Line 27: Beeswax is being : deprecated soon. > BTW, is there a timeline or any blockers for this? I know there is a review out for changing the default: https://gerrit.cloudera.org/#/c/16327/ http://gerrit.cloudera.org:8080/#/c/16406/2/be/src/service/impala-server.h File be/src/service/impala-server.h: http://gerrit.cloudera.org:8080/#/c/16406/2/be/src/service/impala-server.h@773 PS2, Line 773: std:: > nit: can use string directly Done http://gerrit.cloudera.org:8080/#/c/16406/2/be/src/service/impala-server.h@784 PS2, Line 784: JsonProfileToStringProfile > nit: JsonProfileToStringProfile Done http://gerrit.cloudera.org:8080/#/c/16406/2/be/src/service/impala-server.h@785 PS2, Line 785: std::stringstream* string_profile); > nit: I think our code style tries to put the input vars before the output v Done http://gerrit.cloudera.org:8080/#/c/16406/2/be/src/service/impala-server.h@787 PS2, Line 787: /// Set the profile (or thrift_profile) field for the given TGetRuntimeProfileResp > Could you add a method comment for this? Also move the 'request' to be the Done http://gerrit.cloudera.org:8080/#/c/16406/3/shell/impala_shell.py File shell/impala_shell.py: http://gerrit.cloudera.org:8080/#/c/16406/3/shell/impala_shell.py@997 PS3, Line 997: > flake8: E251 unexpected spaces around keyword / parameter equals Done http://gerrit.cloudera.org:8080/#/c/16406/3/shell/impala_shell.py@997 PS3, Line 997: > flake8: E251 unexpected spaces around keyword / parameter equals Done http://gerrit.cloudera.org:8080/#/c/16406/2/tests/custom_cluster/test_shell_interactive.py File tests/custom_cluster/test_shell_interactive.py: http://gerrit.cloudera.org:8080/#/c/16406/2/tests/custom_cluster/test_shell_interactive.py@71 PS2, Line 71: > Also test about the -p or --show_profiles option? Done http://gerrit.cloudera.org:8080/#/c/16406/3/tests/custom_cluster/test_shell_interactive.py File tests/custom_cluster/test_shell_interactive.py: http://gerrit.cloudera.org:8080/#/c/16406/3/tests/custom_cluster/test_shell_interactive.py@61 PS3, Line 61: " > flake8: E501 line too long (91 > 90 characters) Done http://gerrit.cloudera.org:8080/#/c/16406/3/tests/custom_cluster/test_shell_interactive.py@77 PS3, Line 77: > flake8: W293 blank line contains whitespace Done http://gerrit.cloudera.org:8080/#/c/16406/3/tests/custom_cluster/test_shell_interactive.py@77 PS3, Line 77: > line has trailing whitespace Done -- To view, visit http://gerrit.cloudera.org:8080/16406 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I89cee02947b311e7bf9c7274f47dfc7214c1bb65 Gerrit-Change-Number: 16406 Gerrit-PatchSet: 3 Gerrit-Owner: Sahil Takiar <stak...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Sahil Takiar <stak...@cloudera.com> Gerrit-Comment-Date: Thu, 10 Sep 2020 02:48:43 +0000 Gerrit-HasComments: Yes
