Qifan Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/16392 )
Change subject: [WIP] MPALA-10075: Reuse unchanged partition instances ...................................................................... Patch Set 1: (3 comments) Seems like a good optimization! http://gerrit.cloudera.org:8080/#/c/16392/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/16392/1//COMMIT_MSG@17 PS1, Line 17: Manually I know it is a WIP but maybe add several tests to automate the testing new functionality. There can be a number of dimensions to be tested. http://gerrit.cloudera.org:8080/#/c/16392/1/fe/src/main/java/org/apache/impala/catalog/FileMetadataLoader.java File fe/src/main/java/org/apache/impala/catalog/FileMetadataLoader.java: http://gerrit.cloudera.org:8080/#/c/16392/1/fe/src/main/java/org/apache/impala/catalog/FileMetadataLoader.java@76 PS1, Line 76: fds Not clear on the abbreviation. Maybe hdfsPartitionChanged_? http://gerrit.cloudera.org:8080/#/c/16392/1/fe/src/main/java/org/apache/impala/catalog/HdfsPartition.java File fe/src/main/java/org/apache/impala/catalog/HdfsPartition.java: http://gerrit.cloudera.org:8080/#/c/16392/1/fe/src/main/java/org/apache/impala/catalog/HdfsPartition.java@1548 PS1, Line 1548: numRows_ == oldInstance_.numRows_ I wonder if the following situation qualifies a change. 1. A file with 1000 rows is removed; 2. Two files are added, each with 500 rows. -- To view, visit http://gerrit.cloudera.org:8080/16392 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2dd645c260d271291021e52fdac4b74924df1170 Gerrit-Change-Number: 16392 Gerrit-PatchSet: 1 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Qifan Chen <[email protected]> Gerrit-Comment-Date: Thu, 10 Sep 2020 20:54:06 +0000 Gerrit-HasComments: Yes
