Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/16449 )
Change subject: IMPALA-10168(part-1): Expose JSON catalog objects in catalogd's debug page ...................................................................... Patch Set 3: (14 comments) http://gerrit.cloudera.org:8080/#/c/16449/2/be/src/catalog/catalog-json.cc File be/src/catalog/catalog-json.cc: http://gerrit.cloudera.org:8080/#/c/16449/2/be/src/catalog/catalog-json.cc@134 PS2, Line 134: Value type_name(_TTableType_VALUES_TO_NAMES.find(table.table_type)->second, > line too long (91 > 90) Done http://gerrit.cloudera.org:8080/#/c/16449/2/tests/webserver/test_web_pages.py File tests/webserver/test_web_pages.py: http://gerrit.cloudera.org:8080/#/c/16449/2/tests/webserver/test_web_pages.py@349 PS2, Line 349: t > flake8: W601 .has_key() is deprecated, use 'in' Done http://gerrit.cloudera.org:8080/#/c/16449/2/tests/webserver/test_web_pages.py@352 PS2, Line 352: t > flake8: W601 .has_key() is deprecated, use 'in' Done http://gerrit.cloudera.org:8080/#/c/16449/2/tests/webserver/test_web_pages.py@363 PS2, Line 363: t > flake8: W601 .has_key() is deprecated, use 'in' Done http://gerrit.cloudera.org:8080/#/c/16449/2/tests/webserver/test_web_pages.py@367 PS2, Line 367: " > flake8: W601 .has_key() is deprecated, use 'in' Done http://gerrit.cloudera.org:8080/#/c/16449/2/tests/webserver/test_web_pages.py@373 PS2, Line 373: t > flake8: W601 .has_key() is deprecated, use 'in' Done http://gerrit.cloudera.org:8080/#/c/16449/2/tests/webserver/test_web_pages.py@377 PS2, Line 377: s > flake8: W601 .has_key() is deprecated, use 'in' Done http://gerrit.cloudera.org:8080/#/c/16449/2/tests/webserver/test_web_pages.py@379 PS2, Line 379: o > flake8: W601 .has_key() is deprecated, use 'in' Done http://gerrit.cloudera.org:8080/#/c/16449/2/tests/webserver/test_web_pages.py@381 PS2, Line 381: " > flake8: W601 .has_key() is deprecated, use 'in' Done http://gerrit.cloudera.org:8080/#/c/16449/2/tests/webserver/test_web_pages.py@382 PS2, Line 382: n > flake8: W601 .has_key() is deprecated, use 'in' Done http://gerrit.cloudera.org:8080/#/c/16449/2/tests/webserver/test_web_pages.py@383 PS2, Line 383: o > flake8: W601 .has_key() is deprecated, use 'in' Done http://gerrit.cloudera.org:8080/#/c/16449/2/tests/webserver/test_web_pages.py@384 PS2, Line 384: a > flake8: W601 .has_key() is deprecated, use 'in' Done http://gerrit.cloudera.org:8080/#/c/16449/2/tests/webserver/test_web_pages.py@385 PS2, Line 385: > flake8: W601 .has_key() is deprecated, use 'in' Done http://gerrit.cloudera.org:8080/#/c/16449/2/tests/webserver/test_web_pages.py@386 PS2, Line 386: a > flake8: W601 .has_key() is deprecated, use 'in' Done -- To view, visit http://gerrit.cloudera.org:8080/16449 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I15f256b4e3f5206c7140746694106e03b0a4ad92 Gerrit-Change-Number: 16449 Gerrit-PatchSet: 3 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Thu, 17 Sep 2020 02:48:38 +0000 Gerrit-HasComments: Yes
