Hello Tim Armstrong, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/16469
to look at the new patch set (#6).
Change subject: IMPALA-10171: Create query options for local time related flags
......................................................................
IMPALA-10171: Create query options for local time related flags
convert_legacy_hive_parquet_utc_timestamps and
use_local_tz_for_unix_timestamp_conversions were controllable only by
flags until now. After this change the old flags are only used on the
Coordinator to set the defaults for the query options.
If default_query_options also sets these query options, it will
take precedence over the old flags.
Possible follow up work:
- the old flags could be deprecated, as default_query_options
can be used to set this on a server level
- testing these functionalities no longer needs custom cluster
tests - rewriting the existing tests could speed up test
execution
Testing:
- expr-test was rewritten to use the query option instead of the flag
- extended the custom cluster tests for the old flags to also use the
query options
- ran related tests
Change-Id: I5c4252d1c8f8e224c1d0e8234f09374bcc0c6f68
---
M be/src/exec/parquet/hdfs-parquet-scanner.cc
M be/src/exec/parquet/parquet-column-readers.cc
M be/src/exprs/expr-test.cc
M be/src/exprs/timestamp-functions.h
M be/src/runtime/runtime-state.cc
M be/src/runtime/runtime-state.h
M be/src/service/impala-server.cc
M be/src/service/query-options.cc
M be/src/service/query-options.h
M common/thrift/ImpalaInternalService.thrift
M common/thrift/ImpalaService.thrift
M
testdata/workloads/functional-query/queries/QueryTest/utc-timestamp-functions.test
M tests/custom_cluster/test_hive_parquet_timestamp_conversion.py
M tests/custom_cluster/test_local_tz_conversion.py
14 files changed, 183 insertions(+), 37 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/69/16469/6
--
To view, visit http://gerrit.cloudera.org:8080/16469
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I5c4252d1c8f8e224c1d0e8234f09374bcc0c6f68
Gerrit-Change-Number: 16469
Gerrit-PatchSet: 6
Gerrit-Owner: Csaba Ringhofer <[email protected]>
Gerrit-Reviewer: Csaba Ringhofer <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Tim Armstrong <[email protected]>
