Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/16472 )
Change subject: IMPALA-9652: CTAS doesn't respect transactional properties ...................................................................... Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/16472/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/16472/1//COMMIT_MSG@9 PS1, Line 9: Because of a bug the INSERT part of a CTAS statement didn't > Can you add more info about how we worked before the change, and how we wil Done http://gerrit.cloudera.org:8080/#/c/16472/1//COMMIT_MSG@10 PS1, Line 10: transaction > Do I understand well that we are still not transactional in a multi table s Yes, it works like the INSERT statements. IMPALA-8788 is tracking the transactional behavior that you described. It would be a bigger chunk of work, and with event polling we almost always use the latest snapshots of the tables. But I agree that it should be fixed ideally. http://gerrit.cloudera.org:8080/#/c/16472/1/testdata/workloads/functional-query/queries/QueryTest/acid-insert.test File testdata/workloads/functional-query/queries/QueryTest/acid-insert.test: http://gerrit.cloudera.org:8080/#/c/16472/1/testdata/workloads/functional-query/queries/QueryTest/acid-insert.test@65 PS1, Line 65: ==== : ---- QUERY : drop table insertonly_nopart_ctas; > Is there a reason why we do the cleanup here? The whole DB is dropped after I find it good practice to DROP tables after their last use. E.g. if you are copy pasting some tests it's better to get an error message than to use the wrong table. -- To view, visit http://gerrit.cloudera.org:8080/16472 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6ed96aeadbcead9fdc548da5922a066460ff9f77 Gerrit-Change-Number: 16472 Gerrit-PatchSet: 1 Gerrit-Owner: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Fri, 18 Sep 2020 12:45:24 +0000 Gerrit-HasComments: Yes
