Vihang Karajgaonkar has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/16375 )

Change subject: IMPALA-10076: Reduce partition level update logs
......................................................................


Patch Set 4: Code-Review+2

(1 comment)

Thanks for making the suggested changes. +1. Carrying forward Tim's +1 from 
earlier.

http://gerrit.cloudera.org:8080/#/c/16375/3/fe/src/main/java/org/apache/impala/catalog/PartitionMetaSummary.java
File fe/src/main/java/org/apache/impala/catalog/PartitionMetaSummary.java:

http://gerrit.cloudera.org:8080/#/c/16375/3/fe/src/main/java/org/apache/impala/catalog/PartitionMetaSummary.java@126
PS3, Line 126: // Init the lexico
> Sure. Sorry to make you confused. I refactor this part to be more readable
Thanks, it much easier to understand now.



--
To view, visit http://gerrit.cloudera.org:8080/16375
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic48946b2f8b0be1e73988092d03a004836f1b368
Gerrit-Change-Number: 16375
Gerrit-PatchSet: 4
Gerrit-Owner: Quanlong Huang <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Quanlong Huang <[email protected]>
Gerrit-Reviewer: Tim Armstrong <[email protected]>
Gerrit-Reviewer: Vihang Karajgaonkar <[email protected]>
Gerrit-Comment-Date: Fri, 18 Sep 2020 17:33:57 +0000
Gerrit-HasComments: Yes

Reply via email to