Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16439 )
Change subject: IMPALA-9664: Support hive replication ...................................................................... Patch Set 2: (17 comments) http://gerrit.cloudera.org:8080/#/c/16439/2/fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java File fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java: http://gerrit.cloudera.org:8080/#/c/16439/2/fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java@1131 PS2, Line 1131: * @param insertEventDataList A list of insert event encapsulating the information needed line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/16439/2/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java: http://gerrit.cloudera.org:8080/#/c/16439/2/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@4662 PS2, Line 4662: makeInsertEventData((HdfsTable) table, partVals, newFiles, isInsertOverwrite)); line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/16439/2/fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java File fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java: http://gerrit.cloudera.org:8080/#/c/16439/2/fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java@746 PS2, Line 746: runInsertTest(tableToInsertPart, tableToInsertMulPart, numberOfSelfEventsBefore, false); line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/16439/2/fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java@764 PS2, Line 764: runInsertTest(tableToInsertPart, tableToInsertMulPart, numberOfSelfEventsBefore, true); line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/16439/2/fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java@869 PS2, Line 869: unpartTable.getFileSystem(), new Path(unpartTable.getHdfsBaseDir()), overwrite, "copy_"); line too long (97 > 90) http://gerrit.cloudera.org:8080/#/c/16439/2/tests/custom_cluster/test_event_processing.py File tests/custom_cluster/test_event_processing.py: http://gerrit.cloudera.org:8080/#/c/16439/2/tests/custom_cluster/test_event_processing.py@224 PS2, Line 224: _ flake8: E501 line too long (96 > 90 characters) http://gerrit.cloudera.org:8080/#/c/16439/2/tests/custom_cluster/test_event_processing.py@226 PS2, Line 226: l flake8: E501 line too long (93 > 90 characters) http://gerrit.cloudera.org:8080/#/c/16439/2/tests/custom_cluster/test_event_processing.py@228 PS2, Line 228: ] flake8: E501 line too long (92 > 90 characters) http://gerrit.cloudera.org:8080/#/c/16439/2/tests/custom_cluster/test_event_processing.py@246 PS2, Line 246: ] flake8: E501 line too long (92 > 90 characters) http://gerrit.cloudera.org:8080/#/c/16439/2/tests/custom_cluster/test_event_processing.py@254 PS2, Line 254: _ flake8: E501 line too long (96 > 90 characters) http://gerrit.cloudera.org:8080/#/c/16439/2/tests/custom_cluster/test_event_processing.py@256 PS2, Line 256: l flake8: E501 line too long (93 > 90 characters) http://gerrit.cloudera.org:8080/#/c/16439/2/tests/custom_cluster/test_event_processing.py@265 PS2, Line 265: ] flake8: E501 line too long (92 > 90 characters) http://gerrit.cloudera.org:8080/#/c/16439/2/tests/custom_cluster/test_event_processing.py@274 PS2, Line 274: _ flake8: E501 line too long (96 > 90 characters) http://gerrit.cloudera.org:8080/#/c/16439/2/tests/custom_cluster/test_event_processing.py@276 PS2, Line 276: l flake8: E501 line too long (93 > 90 characters) http://gerrit.cloudera.org:8080/#/c/16439/2/tests/custom_cluster/test_event_processing.py@285 PS2, Line 285: ] flake8: E501 line too long (92 > 90 characters) http://gerrit.cloudera.org:8080/#/c/16439/2/tests/custom_cluster/test_event_processing.py@328 PS2, Line 328: ] flake8: E501 line too long (92 > 90 characters) http://gerrit.cloudera.org:8080/#/c/16439/2/tests/custom_cluster/test_event_processing.py@350 PS2, Line 350: e flake8: E722 do not use bare except' -- To view, visit http://gerrit.cloudera.org:8080/16439 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icaf3fe0adff755ff853960f270ceb45b11a84f0a Gerrit-Change-Number: 16439 Gerrit-PatchSet: 2 Gerrit-Owner: Vihang Karajgaonkar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Fri, 18 Sep 2020 22:36:43 +0000 Gerrit-HasComments: Yes
