Hello Wenzhe Zhou, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/16459
to look at the new patch set (#2).
Change subject: IMPALA-10170: Data race on Webserver::UrlHandler::is_on_nav_bar_
......................................................................
IMPALA-10170: Data race on Webserver::UrlHandler::is_on_nav_bar_
This data race can be reproduced by
TestCompactCatalogUpdates.test_restart_catalogd, although it does not
seem to always occur. The data race was originally reported in a Jenkins
job, but I could not reproduce it locally.
The fix is to acquire a read lock while reading some UrlHandler objects.
I cleaned up some of the other involved variables and made them const.
These variables are set during construction time, and never modified
afterwards.
Testing:
* Ran be and custom cluster TSAN tests
Change-Id: I6923af4754e3fe72b8b04c5303a1e7a79da7613a
---
M be/src/util/webserver.cc
M be/src/util/webserver.h
2 files changed, 3 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/59/16459/2
--
To view, visit http://gerrit.cloudera.org:8080/16459
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I6923af4754e3fe72b8b04c5303a1e7a79da7613a
Gerrit-Change-Number: 16459
Gerrit-PatchSet: 2
Gerrit-Owner: Sahil Takiar <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Sahil Takiar <[email protected]>
Gerrit-Reviewer: Wenzhe Zhou <[email protected]>
