Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16414 )
Change subject: WIP IMPALA-9046: Profile counter that indicates if a JVM pause occurred ...................................................................... Patch Set 2: This makes sense to me. My one ask is to register these counters with PROFILE_DEFINE_COUNTER (or whichever macro fits) and document clearly that it's the global number of GCs, not just the ones caused by this query. -- To view, visit http://gerrit.cloudera.org:8080/16414 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idbaae2f9142b8be94532a0a147668a3d96091b0b Gerrit-Change-Number: 16414 Gerrit-PatchSet: 2 Gerrit-Owner: Sahil Takiar <stak...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Sahil Takiar <stak...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Mon, 21 Sep 2020 16:19:10 +0000 Gerrit-HasComments: No
