Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16456 )
Change subject: IMPALA-9227: Add coverage for query retries caused by RPC failure ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/16456/2/tests/custom_cluster/test_query_retries.py File tests/custom_cluster/test_query_retries.py: http://gerrit.cloudera.org:8080/#/c/16456/2/tests/custom_cluster/test_query_retries.py@41 PS2, Line 41: def _get_rpc_fail_action(port, rpc): It would be nice to have a test for the TransmitData RPC as well. I think currently all these tests run for ExecQueryFInstances only. http://gerrit.cloudera.org:8080/#/c/16456/2/tests/custom_cluster/test_query_retries.py@285 PS2, Line 285: def test_retry_exec_query_rpc_failure(self): I think only either 'test_retry_exec_query_rpc_failure' or 'test_retries_exec_query_rpc_failure' is necessary. I would prefer to keep 'test_retries_exec_query_rpc_failure' since it is more complex (tests multiple queries running concurrently). -- To view, visit http://gerrit.cloudera.org:8080/16456 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6c800a764b22c72d5c408e14fd1bdea5336d7d82 Gerrit-Change-Number: 16456 Gerrit-PatchSet: 2 Gerrit-Owner: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Sahil Takiar <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-Comment-Date: Mon, 21 Sep 2020 18:49:22 +0000 Gerrit-HasComments: Yes
