Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/16385 )
Change subject: IMPALA-9792: Add ability to split kudu scan ranges ...................................................................... Patch Set 2: (2 comments) Testing performance locally showed regression in a lot of queries which can be attributed to the load of running both impala and kudu minicluster on a single machine. This needs more perf testing an actual clusters to come up with a suitable default for mt_dop >1. Therefore, deferring that to a follow on patch and for now only added the query option in this one. http://gerrit.cloudera.org:8080/#/c/16385/1/be/src/service/query-options.h File be/src/service/query-options.h: http://gerrit.cloudera.org:8080/#/c/16385/1/be/src/service/query-options.h@a50 PS1, Line 50: > Was this change an accident? No, this part takes in the last generated query option in order verify the number of options is correct. http://gerrit.cloudera.org:8080/#/c/16385/1/tests/query_test/test_kudu.py File tests/query_test/test_kudu.py: http://gerrit.cloudera.org:8080/#/c/16385/1/tests/query_test/test_kudu.py@1468 PS1, Line 1468: targeted_kudu_scan_range_length) : if mt_dop: > I don't think the < operator works this way - you're going to be comparing Done -- To view, visit http://gerrit.cloudera.org:8080/16385 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia02fd94cc1d13c61bc6cb0765dd2cbe90e9a5ce8 Gerrit-Change-Number: 16385 Gerrit-PatchSet: 2 Gerrit-Owner: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Tue, 22 Sep 2020 00:17:43 +0000 Gerrit-HasComments: Yes
