wangsheng has posted comments on this change. ( http://gerrit.cloudera.org:8080/16446 )
Change subject: IMPALA-10164: Supporting HadoopCatalog for Iceberg table ...................................................................... Patch Set 9: (2 comments) Hi Gabor,Zoltan, thanks for your patient review. I've already submit Jenkin test based on patch 8, all passed, and here is the url: https://jenkins.impala.io/job/pre-review-test/710/. But gerrit-verify-dryrun seems failed. I've already download archive.zip,only found two log files. The failed reason related to "Loading workload 'tpch' using exploration strategy 'core'", no more other information. By the way, I will create another new Jira to change 'iceberg_file_format' to 'iceberg.file_format' after this patch completed. http://gerrit.cloudera.org:8080/#/c/16446/3/fe/src/main/java/org/apache/impala/catalog/IcebergTable.java File fe/src/main/java/org/apache/impala/catalog/IcebergTable.java: http://gerrit.cloudera.org:8080/#/c/16446/3/fe/src/main/java/org/apache/impala/catalog/IcebergTable.java@69 PS3, Line 69: iceberg_file_format > I see this was postponed to a later commit. I'm fine with that but could yo Of course, I will create a new Jira to record this lately. http://gerrit.cloudera.org:8080/#/c/16446/3/fe/src/main/java/org/apache/impala/service/IcebergCatalogOpExecutor.java File fe/src/main/java/org/apache/impala/service/IcebergCatalogOpExecutor.java: http://gerrit.cloudera.org:8080/#/c/16446/3/fe/src/main/java/org/apache/impala/service/IcebergCatalogOpExecutor.java@78 PS3, Line 78: PartitionSpec spec, String database, String table) { : // Each table id inc > Maybe these functions should be private as well. I guess we only want them Done -- To view, visit http://gerrit.cloudera.org:8080/16446 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic1893c50a633ca22d4bca6726c9937b026f5d5ef Gerrit-Change-Number: 16446 Gerrit-PatchSet: 9 Gerrit-Owner: wangsheng <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: wangsheng <[email protected]> Gerrit-Comment-Date: Wed, 23 Sep 2020 02:22:06 +0000 Gerrit-HasComments: Yes
